[SYCL][NFC] Extract specialization constant's processing from sycl-post-link to SYCLPostLink library. #19022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st-link to SYCLPostLink library. This change allows later reuse in the New Offloading Model and sycl-jit.
|
The interface of a function SmallVector<ModuleDesc> MDs;
Modified |= handleSpecializationConstants(MDs, Mode);If you have a better alternative for the function's interface let me know. |
| std::optional<SpecConstantsPass::HandlingMode> Mode, | ||
| bool GenerateModuleDescWithDefaultSpecConsts, | ||
| SmallVectorImpl<module_split::ModuleDesc> *NewModuleDescs) { | ||
| assert((GenerateModuleDescWithDefaultSpecConsts ^ !NewModuleDescs) && |
There was a problem hiding this comment.
This is quite difficult to read. Could we rewrite this to something simpler?
Maybe something like:
Suggested change
| assert((GenerateModuleDescWithDefaultSpecConsts ^ !NewModuleDescs) && | |
| #ifdef NDEBUG | |
| if (GenerateModuleDescWithDefaultSpecConsts) | |
| assert(NewModuleDescs); | |
| #endif |
There was a problem hiding this comment.
How does it look to you now?
There was a problem hiding this comment.
That looks much better, thanks!!
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
approved these changes
Jun 27, 2025
asudarsa
reviewed
Jun 27, 2025
|
|
||
| Modified |= processSpecConstants(MMs[I]); | ||
| } | ||
| Modified |= handleSpecializationConstants( |
There was a problem hiding this comment.
Couple of nits:
- Rename func as processSpecConsts
- The fourth argument can be &MMsWithDefaultSpecConsts and the selection can happen inside processSpecConsts
asudarsa
reviewed
Jun 27, 2025
Comment on lines
+8
to
+9
| // Specialization constants processing consists of lowering and generation | ||
| // of new module with spec consts replaced by default values. |
There was a problem hiding this comment.
Suggested change
| // Specialization constants processing consists of lowering and generation | |
| // of new module with spec consts replaced by default values. | |
| // This file handles processing of metadata and intrinsics related to SYCL specialization constants and generates a | |
| // new module with specialization constants replaced by default values. |
asudarsa
reviewed
Jun 27, 2025
| namespace llvm { | ||
| namespace sycl { | ||
|
|
||
| /// Handling consists of SpecConsts's lowering depending on the given |
There was a problem hiding this comment.
Suggested change
| /// Handling consists of SpecConsts's lowering depending on the given | |
| /// Metadata and intrinsics related to SYCL specialization constants are lowered depending on the given |
asudarsa
reviewed
Jun 27, 2025
| MAM.registerPass([&] { return PassInstrumentationAnalysis(); }); | ||
| RunSpecConst.addPass(std::move(SCP)); | ||
|
|
||
| // Perform the spec constant intrinsics transformation on resulting module. |
There was a problem hiding this comment.
Suggested change
| // Perform the spec constant intrinsics transformation on resulting module. | |
| // Perform the specialization constant intrinsics transformation on resulting module. |
asudarsa
reviewed
Jun 27, 2025
| } | ||
|
|
||
| /// Function generates the copy of the given \p MD where all uses of | ||
| /// Specialization Constants are replaced by corresponding default values. |
There was a problem hiding this comment.
Suggested change
| /// Specialization Constants are replaced by corresponding default values. | |
| /// specialization constants are replaced by corresponding default values. |
asudarsa
reviewed
Jun 27, 2025
| PreservedAnalyses Res = MPM.run(NewMD->getModule(), MAM); | ||
| NewMD->Props.SpecConstsMet = !Res.areAllPreserved(); | ||
| assert(NewMD->Props.SpecConstsMet && | ||
| "This property should be true since the presence of SpecConsts " |
There was a problem hiding this comment.
Can we reword the error to be more precise?
Suggested change
| "This property should be true since the presence of SpecConsts " | |
| "SpecConstsMet should be true since the presence of SpecConsts " |
asudarsa
reviewed
Jun 27, 2025
maksimsab
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows later reuse of specialization constant's processing in the New Offloading Model and sycl-jit.